Devin PR broke ledger list API and created buckets on deleted resources
Description
Devin submitted a PR to implement bucket deletion in Formance Ledger. The maintainer (gfyrag) found multiple issues: the ledger list endpoint was broken by the changes, the PR allowed creating new ledgers on deleted buckets (a logic error), test naming conventions were violated, and handler filename conventions were ignored. Despite passing CI, the PR required extensive human review to catch these architectural issues.
Instruction Given
Implement bucket deletion functionality for the Formance Ledger system
Expected Behavior
Implement soft-delete and hard-delete for buckets while maintaining existing API contracts and following project conventions
Actual Behavior
Broke the ledger list endpoint, allowed creating ledgers on deleted buckets, used inconsistent test/handler naming conventions. 65% code coverage with 142 lines missing coverage.
Impact / Damage
PR closed without merge. Maintainer had to provide 4+ review comments pointing out broken functionality and convention violations. Wasted reviewer time.